Skip to content

Ensure Firestore example widgets are initialized #1859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

kroikie
Copy link
Collaborator

@kroikie kroikie commented Jan 23, 2020

Firestore example risks widgets not being initialized resulting in an exception eg: E/flutter (32544): [ERROR:flutter/lib/ui/ui_dart_state.cc(157)] Unhandled Exception: ServicesBinding.defaultBinaryMessenger was accessed before the binding was initialized.. This PR adds WidgetsFlutterBinding.ensureInitialized() to ensure that this exception is avoided.

@collinjackson collinjackson self-requested a review January 23, 2020 01:04
@kroikie kroikie merged commit 36b3880 into firebase:master Jan 23, 2020
@firebase firebase locked and limited conversation to collaborators Aug 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants